Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add community members page #4970

Merged
merged 13 commits into from
Sep 13, 2024
Merged

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented Aug 6, 2024

This PR adds a page under /community that shows all members in their roles across the OpenTelemetry project. It also includes a script to update this data, if we want to add this to the page, I can turn that into a scheduled workflow.

Preview: https://deploy-preview-4970--opentelemetry.netlify.app/community/members/

cc: @open-telemetry/sig-contributor-experience-approvers

@svrnm svrnm requested a review from a team August 6, 2024 13:45
@opentelemetrybot opentelemetrybot requested a review from a team August 6, 2024 13:45
@theletterf
Copy link
Member

Wow! I love it!

Any chance we'd split members by project using headings?

@svrnm
Copy link
Member Author

svrnm commented Aug 6, 2024

Wow! I love it!

Any chance we'd split members by project using headings?

I purposfully didn't do that, because I wanted to have every person only represented once (except GC/TC), and also not make things to complicated. The per-subproject info is available on their repositories. What I was thinking about as a follow up feature is that there is a filter button and you can change that few to only show you maintainers by SIG

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great idea! The current CSS styling for the tables doesn't work well on small screens though, this is how it looks on a Pixel 7 screen
image

(screenshot from devtools but it looks the same as in my personal device)

@svrnm
Copy link
Member Author

svrnm commented Aug 6, 2024

@mx-psi thanks! I just applied some grid options from bootstrap to address that:

<div class="col-6 col-md-4 col-lg-3 col-xxl-2">

@mx-psi
Copy link
Member

mx-psi commented Aug 6, 2024

You can see the images now :)
image

There are a couple of profile pictures that seem to be lower resolution and look odd, maybe we can enforce the same size for all profile pictures as well?

@codefromthecrypt
Copy link

I like the progress here, might make the icons a bit smaller but no need to action that.

Is there any way to have text of the github ID here without making it messy? Right now I found myself hovering over each image ;)

Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, nice work! ✨ RSLGTM

.cspell.yml Outdated Show resolved Hide resolved
gulp-src/lint-md.js Outdated Show resolved Hide resolved
Signed-off-by: svrnm <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team August 8, 2024 09:18
Copy link
Contributor

@danielgblanco danielgblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

svrnm added 2 commits August 9, 2024 11:14
Signed-off-by: svrnm <[email protected]>
@opentelemetrybot opentelemetrybot requested a review from a team August 9, 2024 09:19
@svrnm
Copy link
Member Author

svrnm commented Aug 9, 2024

There are a couple of profile pictures that seem to be lower resolution and look odd, maybe we can enforce the same size for all profile pictures as well?

The flexible layout provided by bootstrap makes this not a trivial task, but I also do not want to write something on my own. It's not feature perfect, so I would suggest we iterate on it later.

Is there any way to have text of the github ID here without making it messy? Right now I found myself hovering over each image ;)

done

@chalin
Copy link
Contributor

chalin commented Aug 9, 2024

/fix:refcache

@opentelemetrybot
Copy link
Collaborator

You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10325906859

Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: thanks a lot!

@svrnm
Copy link
Member Author

svrnm commented Aug 12, 2024

FYI, I want to present this to the maintainers first (via slack/maintainers call) before merging to get a broad feedback for that.

@@ -0,0 +1,2125 @@
technical-committee:
- name: jsuereth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we show name along with github alias?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would guess so, the name should be accessible via the github API

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from what I understand unfortunately that would need another API call per user, I will leave that out for now and use the github handles

@svrnm
Copy link
Member Author

svrnm commented Sep 5, 2024

Note, that I will need to remove the images from this PR, the images are sourced from github and we do not have full control what does images show and represent, so we have a risk of showing something on the website we don't want to have there.

@codefromthecrypt
Copy link

we have a risk of showing something on the website we don't want to have there.

honestly I did think about this, too, and wondered how we might deal with it

@svrnm
Copy link
Member Author

svrnm commented Sep 9, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@svrnm
Copy link
Member Author

svrnm commented Sep 9, 2024

we have a risk of showing something on the website we don't want to have there.

honestly I did think about this, too, and wondered how we might deal with it

Not showing them is the only viable option. Another one would pulling and storing the images locally, and then reviewing them every time we update the list but that sounds like too much effort for me.

Note, that with the latest commit I fixed that and turned the lists in to html unordered lists and added tags per user with the SIGs

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm
Copy link
Member Author

svrnm commented Sep 13, 2024

/fix:all

@opentelemetrybot
Copy link
Collaborator

@opentelemetrybot
Copy link
Collaborator

fix:all was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@svrnm svrnm added this pull request to the merge queue Sep 13, 2024
Merged via the queue into open-telemetry:main with commit 21ccf0a Sep 13, 2024
5 checks passed
@svrnm svrnm deleted the add-community-members-page branch September 13, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants