-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add community members page #4970
Conversation
Signed-off-by: svrnm <[email protected]>
Wow! I love it! Any chance we'd split members by project using headings? |
I purposfully didn't do that, because I wanted to have every person only represented once (except GC/TC), and also not make things to complicated. The per-subproject info is available on their repositories. What I was thinking about as a follow up feature is that there is a filter button and you can change that few to only show you maintainers by SIG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: svrnm <[email protected]>
@mx-psi thanks! I just applied some grid options from bootstrap to address that:
|
I like the progress here, might make the icons a bit smaller but no need to action that. Is there any way to have text of the github ID here without making it messy? Right now I found myself hovering over each image ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, nice work! ✨ RSLGTM
Signed-off-by: svrnm <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
Signed-off-by: svrnm <[email protected]>
Signed-off-by: svrnm <[email protected]>
The flexible layout provided by bootstrap makes this not a trivial task, but I also do not want to write something on my own. It's not feature perfect, so I would suggest we iterate on it later.
done |
/fix:refcache |
You triggered fix:refcache action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10325906859 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot!
FYI, I want to present this to the maintainers first (via slack/maintainers call) before merging to get a broad feedback for that. |
@@ -0,0 +1,2125 @@ | |||
technical-committee: | |||
- name: jsuereth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we show name along with github alias?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would guess so, the name should be accessible via the github API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from what I understand unfortunately that would need another API call per user, I will leave that out for now and use the github handles
Note, that I will need to remove the images from this PR, the images are sourced from github and we do not have full control what does images show and represent, so we have a risk of showing something on the website we don't want to have there. |
honestly I did think about this, too, and wondered how we might deal with it |
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10777715617 |
Not showing them is the only viable option. Another one would pulling and storing the images locally, and then reviewing them every time we update the list but that sounds like too much effort for me. Note, that with the latest commit I fixed that and turned the lists in to html unordered lists and added tags per user with the SIGs |
IMPORTANT: (RE-)RUN
|
Signed-off-by: svrnm <[email protected]>
/fix:all |
You triggered fix:all action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/10846574128 |
IMPORTANT: (RE-)RUN
|
This PR adds a page under /community that shows all members in their roles across the OpenTelemetry project. It also includes a script to update this data, if we want to add this to the page, I can turn that into a scheduled workflow.
Preview: https://deploy-preview-4970--opentelemetry.netlify.app/community/members/
cc: @open-telemetry/sig-contributor-experience-approvers